Expose EC2 instance lifecycle as label #6914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-brazil
reviewed
Mar 2, 2020
docs/configuration/configuration.md
Outdated
| @@ -430,6 +430,7 @@ The following meta labels are available on targets during [relabeling](#relabel_ | |||
| * `__meta_ec2_instance_id`: the EC2 instance ID | |||
| * `__meta_ec2_instance_state`: the state of the EC2 instance | |||
| * `__meta_ec2_instance_type`: the type of the EC2 instance | |||
| * `__meta_ec2_instance_lifecycle`: the lifecycle of the EC2 instance, set only for 'spot' or 'scheduled' instances, absent otherwise | |||
Signed-off-by: Alex Gaganov <alex.gaganov@fiverr.com>
ghost
force-pushed
the
ec2sd_add_lifecycle_label
branch
from
e736856
to
c4eed12
Compare
|
Thanks! |
boyskila
pushed a commit
to boyskila/prometheus
that referenced
this pull request
Mar 3, 2020
Signed-off-by: Alex Gaganov <alex.gaganov@fiverr.com>
boyskila
pushed a commit
to boyskila/prometheus
that referenced
this pull request
Mar 3, 2020
Signed-off-by: Alex Gaganov <alex.gaganov@fiverr.com> Signed-off-by: blalov <boiskila@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Gaganov alex.gaganov@fiverr.com
This change exposes the
InstanceLifecycleattribute during EC2 service discovery and makes it available as a__meta_ec2_instance_lifecyclelabel. The attribute's value can be eitherspotorscheduled. In the case of "regular" instance, the attribute will benil.The new label will come in handy when there's a need to distinguish between
spotandon-demandinstances.There was an attempt to address this in #6017, however, the PR has some pending comments and got stale due to inactivity :-(
@brian-brazil your input would be greatly appreciated.